Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added concurrency guide. #677

Merged
merged 2 commits into from
Sep 22, 2023
Merged

Added concurrency guide. #677

merged 2 commits into from
Sep 22, 2023

Conversation

squidarth
Copy link
Collaborator

@squidarth squidarth commented Sep 22, 2023

screencapture-localhost-3000-guides-concurrency-2023-09-22-15_32_01

Copy link
Member

@philipkiely-baseten philipkiely-baseten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only thing I worry about this doc is it's getting pretty deep into Baseten-specific features. We should def ship it for now as is, and once I have more Baseten docs up I might move some of the information around or add some redirects.

docs/guides/concurrency.mdx Outdated Show resolved Hide resolved
Co-authored-by: Philip Kiely - Baseten <98474633+philipkiely-baseten@users.noreply.github.com>
@squidarth
Copy link
Collaborator Author

The only thing I worry about this doc is it's getting pretty deep into Baseten-specific features. We should def ship it for now as is, and once I have more Baseten docs up I might move some of the information around or add some redirects.

for sure -- going to merge for now, but feel free to move this to the baseten side if you feel it belongs there.

Another thing to note is that I am not thrilled with the way all of this works today. We don't want to block documentation on future feature development, but in my ideal world, both of these types of concurrency are configured in the Truss config

@squidarth squidarth merged commit 59fda14 into main Sep 22, 2023
3 checks passed
@squidarth squidarth deleted the sshanker/concurrency-guide branch September 22, 2023 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants