-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 0.8.1rc1 #814
Closed
Closed
Release 0.8.1rc1 #814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Allow specifying requirements via requirements.txt file * Update truss/truss_config.py Co-authored-by: helenlyang <helen.yang@baseten.co> * Update truss/tests/test_model_inference.py Co-authored-by: helenlyang <helen.yang@baseten.co> * Review comments and docs --------- Co-authored-by: helenlyang <helen.yang@baseten.co>
* prints have been intercepted! * clean up * fix streams * fix typo * test added * minor fixes * add assert fix
With this PR, we no longer spawn a background thread for detecting changes and creating patches. This should mitigate the issue where another thread unnecessarily consumes CPU cycles and slows down truss watch. In addition to the speedups, removing TrussFileSyncer involved changing the logger used in BasetenRemote.patch. This fixes a bug that resulted in the info logs in BasetenRemote.patch not being logged.
Some easy improvements to `truss watch` CLI logs: * Most logs are printed instead of using `logger`. There's no need to expose which module is logging to the user * Color codes logs * Adds an `Applying patch...` spinner before the patch request is sent to server. Waiting on a response from the server after sending the patch request is the lengthiest part of the patching process, so I think this additional bit of feedback would be useful to the user
Instead of merging this. I'm just gonna run the action on this branch. |
which action? |
squidarth
approved these changes
Feb 1, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating Truss from "0.7.23" to 0.8.1rc1. PLEASE ENSURE YOU MERGE, NOT SQUASH