fix: support external oci_image targets #622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thesayyn
force-pushed
the
external_oci_image
branch
from
4acf057
to
bad952d
Compare
|
@thesayyn FYI seems like the blocker has been resolved upstream. |
|
We need a new version of regctl before we can solve it here. |
thesayyn
force-pushed
the
external_oci_image
branch
from
292c60a
to
33333eb
Compare
alexeagle
approved these changes
Jul 18, 2024
|
@thesayyn this PR broke our BCR publishing bazelbuild/bazel-central-registry#2563 because it assumes e2e/ can reference examples/. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #588, blocked on: regclient/regclient#763