Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add CHANGELOG to make summarizing releases easier. #1382

Merged
merged 1 commit into from
Aug 21, 2023
Merged

feat: add CHANGELOG to make summarizing releases easier. #1382

merged 1 commit into from
Aug 21, 2023

Conversation

rickeylev
Copy link
Contributor

This adds a changelog in a keepachanglog.com style format.

It's initially populated with currently unreleased behavior and the last release's (0.24.0) changes.

Work towards #1361

@rickeylev rickeylev requested a review from groodt August 19, 2023 07:45
@rickeylev
feat: add CHANGELOG to make summarizing releases easier.
f4b0080 
This adds a changelog in a keepachanglog.com style format.

It's initially populated with currently unreleased behavior and the
last release's (0.24.0) changes.

Work towards bazelbuild#1361
groodt
groodt approved these changes Aug 20, 2023
View reviewed changes
Copy link
Collaborator

@groodt groodt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

aignas
aignas approved these changes Aug 21, 2023
View reviewed changes
Copy link
Collaborator

@aignas aignas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will make writing changelog entries much nicer.

Should the PR template be updated as well to remind people about the need to add a change to this file?

@chrislovecnm chrislovecnm added this pull request to the merge queue Aug 21, 2023
Merged via the queue into bazelbuild:main with commit 7d16af6 Aug 21, 2023
1 check passed
@rickeylev
Copy link
Contributor Author

This will make writing changelog entries much nicer.

Should the PR template be updated as well to remind people about the need to add a change to this file?

Good idea! #1384 sent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aignas aignas aignas approved these changes

@groodt groodt groodt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rickeylev @aignas @groodt @chrislovecnm