-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/auto scroll to chapter #169
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for your contribution, Edward!
I've also experienced this annoying bug so I'm very glad someone has finally addressed it. Thanks!
I'm sorry but it's not working fine for me on Desktop. Testing Skjulte Skatter March 2023.
|
Hmm... This is weird, can't seem to reproduce the issue here. Especially, I really can't understand why you would be able to scroll infinitely the same publication. Can you see any particular error in the console? Also, which language did you use when testing? |
I don't get any error message in the console. The language is Norwegian. |
I'm not able to reproduce this issue, even when following the exact same step. Maybe we should schedule a session of pair programming, so we can look at it together? |
There is an annoying bug (not consistent though) where you don't reach the beginning of a chapter when clicking on it in the sidebar (or when loading a given chapter via a link).
This PR fixes this issue.
I also fixed the numbering of the items in the sidebar to be consistent with the chapter ID