Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/auto scroll to chapter #169

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

Dr-Wade
Copy link
Collaborator

@Dr-Wade Dr-Wade commented Mar 1, 2023

There is an annoying bug (not consistent though) where you don't reach the beginning of a chapter when clicking on it in the sidebar (or when loading a given chapter via a link).

This PR fixes this issue.
I also fixed the numbering of the items in the sidebar to be consistent with the chapter ID

@Dr-Wade Dr-Wade requested a review from cs1m0n March 1, 2023 17:37
Copy link
Member

@cs1m0n cs1m0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for your contribution, Edward!
I've also experienced this annoying bug so I'm very glad someone has finally addressed it. Thanks!

src/mixins/reader.js Show resolved Hide resolved
@Dr-Wade Dr-Wade linked an issue Mar 3, 2023 that may be closed by this pull request
@cs1m0n
Copy link
Member

cs1m0n commented Mar 6, 2023

I'm sorry but it's not working fine for me on Desktop. Testing Skjulte Skatter March 2023.
Both the scroll location is wrong and the menu started behaving very strange:

  • the chapter id you get in the url is not correct
  • you can scroll infinitely the same publication (over and over again)

@Dr-Wade
Copy link
Collaborator Author

Dr-Wade commented Mar 7, 2023

Hmm... This is weird, can't seem to reproduce the issue here. Especially, I really can't understand why you would be able to scroll infinitely the same publication.

Can you see any particular error in the console? Also, which language did you use when testing?

@cs1m0n
Copy link
Member

cs1m0n commented Mar 7, 2023

I don't get any error message in the console. The language is Norwegian.
The strange behaviour starts after I navigate to a chapter from the menu.
I've sent you a screen recording. You can't see the address bar, but after first choosing a chapter, that id is remembered and whenever I click on chapter 1, I get redirected to the remembered chapter id.
I guess the infinite scrolling is because chapter 1 is redirecting to the remembered chapter id.

@Dr-Wade
Copy link
Collaborator Author

Dr-Wade commented Mar 15, 2023

I'm not able to reproduce this issue, even when following the exact same step. Maybe we should schedule a session of pair programming, so we can look at it together?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inline links wrong location in page
2 participants