Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: respond the api with user only openings #341

Merged
merged 2 commits into from
Jul 26, 2024

Conversation

RMCampos
Copy link
Contributor

@RMCampos RMCampos commented Jul 19, 2024

Description

Respond only with user openings, and in case there's none for that user, respond with an empty array.

Fixes SILVA-456

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Unit tests

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments


Thanks for the PR!

Any successful deployments (not always required) will be available below.

Backend: https://nr-silva-341-backend.apps.silver.devops.gov.bc.ca/actuator/health
Frontend: https://nr-silva-41-frontend.apps.silver.devops.gov.bc.ca

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

@RMCampos RMCampos self-assigned this Jul 19, 2024
@RMCampos RMCampos marked this pull request as ready for review July 19, 2024 16:56
@RMCampos RMCampos enabled auto-merge (squash) July 24, 2024 16:34
@RMCampos RMCampos merged commit 1b2d895 into main Jul 26, 2024
16 checks passed
@RMCampos RMCampos deleted the fix/456-only-user-openings branch July 26, 2024 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants