Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add filter submitted to section 108 frpa #346

Merged
merged 2 commits into from
Aug 16, 2024

Conversation

RMCampos
Copy link
Contributor

@RMCampos RMCampos commented Aug 12, 2024

Description

  • Add actual filter for the Submission of Openings under Section 108 FRPA.

Fixes SILVA-466

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Tested locally and with unit tests;

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments


Thanks for the PR!

Any successful deployments (not always required) will be available below.

Backend: https://nr-silva-346-backend.apps.silver.devops.gov.bc.ca/actuator/health
Frontend: https://nr-silva-46-frontend.apps.silver.devops.gov.bc.ca

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

@RMCampos RMCampos self-assigned this Aug 12, 2024
@RMCampos RMCampos marked this pull request as ready for review August 12, 2024 17:54
Copy link
Collaborator

@jazzgrewal jazzgrewal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Job!

@RMCampos RMCampos merged commit 3c2da54 into main Aug 16, 2024
16 checks passed
@RMCampos RMCampos deleted the feat/silva-466-filter-frpa-section-108 branch August 16, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants