Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pvc cert volume name #399

Merged
merged 19 commits into from
Oct 11, 2024
Merged

fix: pvc cert volume name #399

merged 19 commits into from
Oct 11, 2024

Conversation

RMCampos
Copy link
Contributor

@RMCampos RMCampos commented Oct 11, 2024

Description

Fix the PVC name for the Certificate and the init container.

No issue related.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • This change will be tested after merge.

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments


Thanks for the PR!

Any successful deployments (not always required) will be available below.

Backend: https://nr-silva-399-backend.apps.silver.devops.gov.bc.ca/actuator/health
Frontend: https://nr-silva-49-frontend.apps.silver.devops.gov.bc.ca

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

Copy link
Collaborator

@jazzgrewal jazzgrewal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One of the last approvals before you go. Great job as always!

@RMCampos RMCampos merged commit 23183dc into main Oct 11, 2024
16 checks passed
@RMCampos RMCampos deleted the fix/pvc-cert-volume-name branch October 11, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants