fix(SILVA-551): fixing dashboard issues #448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Small code refactor to change some dependencies
Swagger is not required for the backend api as the only consumer should be the frontend app
- renamed endpoint to fix typo - removed old/deprecated endpoint - removed unused method
- renamed file and functions - changed tests to match for new name - changed test to add check for empty state
paulushcgcj
requested review from
carolinemwood,
jazzgrewal,
DerekRoberts and
gpascucci
as code owners
DerekRoberts
approved these changes
Nov 8, 2024
|
Merging as it was approved by Nanda |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please provide a summary of the change and the issue fixed. Please include relevant context. List dependency changes.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
Checklist
Further comments
Thanks for the PR!
Any successful deployments (not always required) will be available below.
Backend: https://nr-silva-448-backend.apps.silver.devops.gov.bc.ca/actuator/health
Frontend: https://nr-silva-48-frontend.apps.silver.devops.gov.bc.ca
Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow