fix(SILVA-535): updates to cleard advanced search component #464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gpascucci
requested review from
carolinemwood,
jazzgrewal,
paulushcgcj and
DerekRoberts
as code owners
paulushcgcj
changed the title
paulushcgcj
requested changes
Nov 13, 2024
| const [selectedCategories, setSelectedCategories] = useState<any[]>([]); | ||
|
|
||
| useEffect(() => { | ||
| console.log("Use Effect in child is being called.", filters); |
There was a problem hiding this comment.
Remove this console.log here
| import "./OpeningsSearchBar.scss"; | ||
| import { Search, Button, FlexGrid, Row, Column, DismissibleTag } from "@carbon/react"; | ||
| import * as Icons from "@carbon/icons-react"; | ||
| import AdvancedSearchDropdown from "../AdvancedSearchDropdown"; | ||
| import SearchFilterBar from "../SearchFilterBar"; | ||
| import { useOpeningsSearch } from "../../../../contexts/search/OpeningsSearch"; | ||
| import { countActiveFilters } from "../../../../utils/searchUtils"; | ||
| import { callbackify } from "util"; | ||
| import { c } from "vite/dist/node/types.d-aGj9QkWt"; |
There was a problem hiding this comment.
Remove this, please. This was probably added by vscode while you were typing.
| @@ -37,6 +37,7 @@ export const OpeningsSearchProvider: React.FC<{ children: ReactNode }> = ({ chil | |||
|
|
|||
| // Function to clear individual filter field by key | |||
| const clearIndividualField = (key: string) => { | |||
| console.log("Clearing individual field", key); | |||
There was a problem hiding this comment.
Please remove this console.log
…clear-date-filters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please provide a summary of the change and the issue fixed. Please include relevant context. List dependency changes.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist
Further comments
Thanks for the PR!
Any successful deployments (not always required) will be available below.
Backend: https://nr-silva-464-backend.apps.silver.devops.gov.bc.ca/actuator/health
Frontend: https://nr-silva-14-frontend.apps.silver.devops.gov.bc.ca
Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow