Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: changing pagination parameters #490

Merged
merged 5 commits into from
Nov 20, 2024
Merged

chore: changing pagination parameters #490

merged 5 commits into from
Nov 20, 2024

Conversation

paulushcgcj
Copy link
Contributor

@paulushcgcj paulushcgcj commented Nov 20, 2024

Description

Trying to make the query faster by changing some of the pagination parameters

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

@paulushcgcj paulushcgcj marked this pull request as ready for review November 20, 2024 20:05
@paulushcgcj paulushcgcj enabled auto-merge (squash) November 20, 2024 20:05
DerekRoberts
DerekRoberts previously approved these changes Nov 20, 2024
Copy link
Member

@DerekRoberts DerekRoberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like this one was painful.

Copy link
Collaborator

@jazzgrewal jazzgrewal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Job @paulushcgcj

@paulushcgcj paulushcgcj merged commit d73aa05 into main Nov 20, 2024
21 checks passed
@paulushcgcj paulushcgcj deleted the fix/search branch November 20, 2024 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants