Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(SILVA-569): add new column options in the Search Screen #497

Merged
merged 17 commits into from
Nov 25, 2024

Conversation

jazzgrewal
Copy link
Collaborator

@jazzgrewal jazzgrewal commented Nov 21, 2024

Description

This PR resolves the following
User story:
As a SILVA user navigating the opening search, when I customize my table view, I want to see all column options, so that I choose what will be my table view

Acceptance criteria:

We are missing the opening number, timber mark, client, free growing, regen delay, and update date (Don't add the opening type for now)
Make the opening ID fixed as a column and inside of the edit columns, so the user can't uncheck it

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Tested Locally

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

@paulushcgcj paulushcgcj changed the title fix(addNewColumnsToSearch): (SILVA-569) add new column options in the Search Screen fix(SILVA-569): add new column options in the Search Screen Nov 21, 2024
paulushcgcj
paulushcgcj previously approved these changes Nov 22, 2024
@paulushcgcj paulushcgcj merged commit 4e576ea into main Nov 25, 2024
19 of 20 checks passed
@paulushcgcj paulushcgcj deleted the fix/addNewColumnsToSearchScreen branch November 25, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants