generated from bcgov/quickstart-openshift
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(SILVA-569): add new column options in the Search Screen #497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merging main to update the branch head
jazzgrewal
requested review from
carolinemwood,
paulushcgcj,
DerekRoberts and
gpascucci
as code owners
November 21, 2024 18:38
paulushcgcj
changed the title
fix(addNewColumnsToSearch): (SILVA-569) add new column options in the Search Screen
fix(SILVA-569): add new column options in the Search Screen
Nov 21, 2024
Merging form the main after the design fix
paulushcgcj
previously approved these changes
Nov 22, 2024
Co-authored-by: Paulo Gomes da Cruz Junior <paulo.cruz@gov.bc.ca>
paulushcgcj
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves the following
User story:
As a SILVA user navigating the opening search, when I customize my table view, I want to see all column options, so that I choose what will be my table view
Acceptance criteria:
We are missing the opening number, timber mark, client, free growing, regen delay, and update date (Don't add the opening type for now)
Make the opening ID fixed as a column and inside of the edit columns, so the user can't uncheck it
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist
Further comments
Thanks for the PR!
Deployments, as required, will be available below:
Please create PRs in draft mode. Mark as ready to enable:
After merge, new images are deployed in: