Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MMI-244 Updated CBRA reports #2368

Merged
merged 3 commits into from
Dec 19, 2024
Merged

MMI-244 Updated CBRA reports #2368

merged 3 commits into from
Dec 19, 2024

Conversation

laidaoyu
Copy link
Collaborator

  • added new cbra report postgres functions
  • added migrations
  • updated cbra report excel format

- added new cbra report postgres functions
- added migrations
- updated cbra report excel format
Copy link
Collaborator

@nehalaggarwal-bcgov nehalaggarwal-bcgov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

Copy link
Collaborator

@Fosol Fosol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that you moved a lot of the work to the database. I wonder though if temporary tables are ideal and performant. I'm sure they're a lot more performant than pulling all that data to the API. Good work.

- added a new view
- updated functions
- fixed minor issues
- updated cbra function
@laidaoyu laidaoyu merged commit 291f655 into dev Dec 19, 2024
5 checks passed
@laidaoyu laidaoyu deleted the MMI-244 branch December 19, 2024 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants