Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redirect 234 #273

Merged
merged 11 commits into from
Jun 1, 2023
Merged

Redirect 234 #273

merged 11 commits into from
Jun 1, 2023

Conversation

popkinj
Copy link
Contributor

@popkinj popkinj commented May 18, 2023

  • When scanning a qr-code with the bc wallet, the default behaviour still occurs
  • When scanning with a smartphones camera the user is redirected to a webpage
  • The webpage is a configured variable

Note: Within the development environment, Ngrok is currently blocking the redirect to a webpage. This will get corrected by the this ticket

@popkinj popkinj requested a review from esune May 18, 2023 18:37
esune
esune requested changes May 19, 2023
View reviewed changes
oidc-controller/api/core/config.py Show resolved Hide resolved
docker/manage Outdated Show resolved Hide resolved
@popkinj
Stopping polling on denial response
504bb3a 
Signed-off-by: Jamie Popkin <popkinj@littleearth.ca>
@popkinj
This is how we can detect a wallet vs other
cf59019 
Signed-off-by: Jamie Popkin <popkinj@littleearth.ca>
@popkinj
Here is the redirect for cameras not connected to a wallet
909610d 
Signed-off-by: Jamie Popkin <popkinj@littleearth.ca>
@popkinj
Cleaning things up a little
df248e9 
Signed-off-by: Jamie Popkin <popkinj@littleearth.ca>
@popkinj
This may be the best way to toggle between template and url
acda698 
Signed-off-by: Jamie Popkin <popkinj@littleearth.ca>
@esune esune mentioned this pull request May 29, 2023
Open
9 tasks
@popkinj
Template is loading
0a9a37d 
Signed-off-by: Jamie Popkin <popkinj@littleearth.ca>
@popkinj
Copy link
Contributor Author

popkinj commented May 29, 2023

Will continue next by filling the template with some minimal content and styling.

@popkinj
Minimal content. Styling next
a921ad1 
Signed-off-by: Jamie Popkin <popkinj@littleearth.ca>
esune
esune reviewed May 30, 2023
View reviewed changes
Copy link
Member

@esune esune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Just a couple comments/suggestions.

docker/manage Outdated Show resolved Hide resolved
oidc-controller/api/routers/presentation_request.py Outdated Show resolved Hide resolved
@popkinj
Page is styled.
c6a2580 
Signed-off-by: Jamie Popkin <popkinj@littleearth.ca>
@popkinj
Copy link
Contributor Author

popkinj commented May 30, 2023

Screenshot_20230530_114226_Chrome

popkinj and others added 3 commits May 30, 2023 14:28
@popkinj
Some optimizations and clean up
3ca63ad 
Signed-off-by: Jamie Popkin <popkinj@littleearth.ca>
@esune
Use consistent naming for NGROK_AUTHTOKEN, ensure newline is added wh…
386c895 
…en copying .env-dev

Signed-off-by: Emiliano Suñé <emiliano.sune@gmail.com>
@esune
Remove commented line
0e42cf0 
Signed-off-by: Emiliano Suñé <emiliano.sune@gmail.com>
@esune esune self-requested a review June 1, 2023 10:32
esune
esune approved these changes Jun 1, 2023
View reviewed changes
Copy link
Member

@esune esune left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Added a small quality-of-life change, other than that this is awesome 🙂

@esune esune merged commit 01ffe6b into 2.0-development Jun 1, 2023
@esune esune deleted the redirect-234 branch June 1, 2023 10:33
@esune esune mentioned this pull request Jun 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@esune esune esune approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@popkinj @esune