Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to QR page #35

Merged
merged 8 commits into from
Jan 27, 2020
Merged

Updates to QR page #35

merged 8 commits into from
Jan 27, 2020

Conversation

esune
Copy link
Member

@esune esune commented Jan 21, 2020

Initial redesign of QR code page

Signed-off-by: Emiliano Suñé <emiliano.sune@gmail.com>
Signed-off-by: Emiliano Suñé <emiliano.sune@gmail.com>
Signed-off-by: Emiliano Suñé <emiliano.sune@gmail.com>
Signed-off-by: Emiliano Suñé <emiliano.sune@gmail.com>
Signed-off-by: Emiliano Suñé <emiliano.sune@gmail.com>
Signed-off-by: Emiliano Suñé <emiliano.sune@gmail.com>
Signed-off-by: Emiliano Suñé <emiliano.sune@gmail.com>
Copy link
Contributor

@swcurran swcurran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a huge fan of the "What's being asked for" section, but John needs to drive that. I've offered a suggestion on the layout. The rest looks good.

I'll leave the code review to Wade.

@swcurran
Copy link
Contributor

Suggestion for cleanup of the "What's being asked for" -

  • Get rid "claim" everywhere.
  • Collapse the triplet into "Source Credential"
  • Make the DID a link that on click pops up the DID
    • could put a link to resolve the DID on the popup.
  • Put an "OR" between the triplets.

Something like:

Field: email
Restrictions:
 - Source Credential: verified-email:1.2.2 DID -OR-
 - Source Credential: iiw_attendance:1.2.4 DID -OR-
 - Source Credential: verified_person:1.22 DID

Would have to handle things like no restrictions, restrictions by schema, restrictions by cred def, restrictions by name, restrictions by value, etc.

@esune
Copy link
Member Author

esune commented Jan 21, 2020

...
Would have to handle things like no restrictions, restrictions by schema, restrictions by cred def, restrictions by name, restrictions by value, etc.

I need to put some thought into this, as I believe it ties in with the updates described in #34 (we don't currently support restrictions by value). We also need to be able to show requested_predicates.

@swcurran would it be okay to track those changes in a separate issue?

@swcurran
Copy link
Contributor

swcurran commented Jan 22, 2020 via email

@esune esune merged commit ef21708 into bcgov:master Jan 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants