Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Present proof 2 #560

Merged
merged 41 commits into from
Jul 26, 2024
Merged

Present proof 2 #560

merged 41 commits into from
Jul 26, 2024

Conversation

Gavinok
Copy link
Contributor

@Gavinok Gavinok commented Jun 20, 2024

No description provided.

Gavinok and others added 22 commits May 22, 2024 11:55
Signed-off-by: Gavin Jaeger-Freeborn <gavinfreeborn@gmail.com>
Signed-off-by: Gavin Jaeger-Freeborn <gavinfreeborn@gmail.com>
Signed-off-by: Gavin Jaeger-Freeborn <gavinfreeborn@gmail.com>
Signed-off-by: Gavin Jaeger-Freeborn <gavinfreeborn@gmail.com>
Signed-off-by: Gavin Jaeger-Freeborn <gavinfreeborn@gmail.com>
Signed-off-by: Gavin Jaeger-Freeborn <gavinfreeborn@gmail.com>
Signed-off-by: Gavin Jaeger-Freeborn <gavinfreeborn@gmail.com>
Signed-off-by: Gavin Jaeger-Freeborn <gavinfreeborn@gmail.com>
…nvvar

Signed-off-by: Gavin Jaeger-Freeborn <gavinfreeborn@gmail.com>
Signed-off-by: Gavin Jaeger-Freeborn <gavinfreeborn@gmail.com>
Signed-off-by: Gavin Jaeger-Freeborn <gavinfreeborn@gmail.com>
Signed-off-by: Gavin Jaeger-Freeborn <gavinfreeborn@gmail.com>
Signed-off-by: Gavin Jaeger-Freeborn <gavinfreeborn@gmail.com>
Signed-off-by: Gavin Jaeger-Freeborn <gavinfreeborn@gmail.com>
Signed-off-by: Gavin Jaeger-Freeborn <gavinfreeborn@gmail.com>
Signed-off-by: Gavin Jaeger-Freeborn <gavinfreeborn@gmail.com>
Signed-off-by: Gavin Jaeger-Freeborn <gavinfreeborn@gmail.com>
Signed-off-by: Gavin Jaeger-Freeborn <gavinfreeborn@gmail.com>
Signed-off-by: Gavin Jaeger-Freeborn <gavinfreeborn@gmail.com>
@Gavinok Gavinok marked this pull request as draft June 20, 2024 16:05
Signed-off-by: Gavin Jaeger-Freeborn <gavinfreeborn@gmail.com>
Signed-off-by: Gavin Jaeger-Freeborn <gavinfreeborn@gmail.com>
Signed-off-by: Gavin Jaeger-Freeborn <gavinfreeborn@gmail.com>
Signed-off-by: Gavin Jaeger-Freeborn <gavinfreeborn@gmail.com>
Signed-off-by: Gavin Jaeger-Freeborn <gavinfreeborn@gmail.com>
@cvarjao
Copy link
Member

cvarjao commented Jul 23, 2024

@loneil , what version of BC Wallet did you test with? version 1.0.18 was release yesterday

@loneil
Copy link
Contributor

loneil commented Jul 23, 2024

@cvarjao for this branch testing proof 2.0 I'm using 1.0.18 build 1801 for both Android and iOS (on the beta on Android but not iOS but looks like same release for today)

@esune
Copy link
Member

esune commented Jul 23, 2024

@loneil yes, unless we have a good reason to drop conenction-less right away we should maintain support for now. We'll plan to slowly move away from it though.

Signed-off-by: Gavin Jaeger-Freeborn <gavinfreeborn@gmail.com>
@cvarjao
Copy link
Member

cvarjao commented Jul 24, 2024

When trying to receive an OOB invite from aca-py via Credo I get some error message in Credo about DID Rotate attachment is missing.

@jamshale
Copy link
Contributor

When trying to receive an OOB invite from aca-py via Credo I get some error message in Credo about DID Rotate attachment is missing.

This issue came up a little while ago but I thought it had been addressed from the aca-py side and closed the issue openwallet-foundation/acapy#3020.

@cvarjao
Copy link
Member

cvarjao commented Jul 24, 2024

So, what would be the correct API call for using did:peer:4?
I've tried using:

http.post(`/out-of-band/create-invitation`,{
            "accept":["didcomm/aip1","didcomm/aip2;env=rfc19"],
            "alias":`Faber\`s 😇 - ${new Date().getTime()}`,
            "goal":"",
            "goal_code":"",
            "handshake_protocols":["https://didcomm.org/didexchange/1.0"],
            "my_label":`Faber\`s 😇 - ${new Date().getTime()}`,
            "protocol_version":"1.1",
            "use_public_did":false,
            "use_did_method": "did:peer:4",
        }, {
            params: {
                "auto_accept": true,
                "multi_use": false,
                "create_unique_did": false,
            },
            headers:{
                'Content-Type': 'application/json',
                'Authorization': `Bearer ${config.auth_token}`
            }
        })

@esune
Copy link
Member

esune commented Jul 24, 2024

So, what would be the correct API call for using did:peer:4? I've tried using:

http.post(`/out-of-band/create-invitation`,{
            "accept":["didcomm/aip1","didcomm/aip2;env=rfc19"],
            "alias":`Faber\`s 😇 - ${new Date().getTime()}`,
            "goal":"",
            "goal_code":"",
            "handshake_protocols":["https://didcomm.org/didexchange/1.0"],
            "my_label":`Faber\`s 😇 - ${new Date().getTime()}`,
            "protocol_version":"1.1",
            "use_public_did":false,
            "use_did_method": "did:peer:4",
        }, {
            params: {
                "auto_accept": true,
                "multi_use": false,
                "create_unique_did": false,
            },
            headers:{
                'Content-Type': 'application/json',
                'Authorization': `Bearer ${config.auth_token}`
            }
        })

Might be best to ask in the ACA-Py Discord or repo rather than in this PR, as this is ACA-Py behaviour (not specific to VC-AuthN).
That being said, i think what you are doing is right: https://aca-py.org/latest/features/QualifiedDIDs/#context

@jamshale
Copy link
Contributor

Just FYI, I think that payload looks correct. If it's not working then I'm not sure why.

Signed-off-by: Gavin Jaeger-Freeborn <gavinfreeborn@gmail.com>
Signed-off-by: Gavin Jaeger-Freeborn <gavinfreeborn@gmail.com>
@Gavinok Gavinok requested a review from loneil July 25, 2024 21:07
Signed-off-by: Gavin Jaeger-Freeborn <gavinfreeborn@gmail.com>
Signed-off-by: Gavin Jaeger-Freeborn <gavinfreeborn@gmail.com>
@Gavinok
Copy link
Contributor Author

Gavinok commented Jul 25, 2024

As Lucas mentioned the body of the attachments are already base64 encoded so I figured we could remove the use of the build method and simply unpack the contents and add the new format field. This should now work with connectionless

@Gavinok Gavinok requested a review from esune July 25, 2024 21:23
@esune
Copy link
Member

esune commented Jul 25, 2024

I am able to scan the QR code in BC Wallet and respond to the proof-request (which is happening QUITE quickly), but then the page in the demo app does not update to the success state and navigate away.

@esune
Copy link
Member

esune commented Jul 25, 2024

I am able to scan the QR code in BC Wallet and respond to the proof-request (which is happening QUITE quickly), but then the page in the demo app does not update to the success state and navigate away.

Nevermind, the issue was with me using a CANdy prod credential to respond at the proof, and that ledger not being in the agent config. Everything works as expected.

esune
esune previously approved these changes Jul 25, 2024
Copy link
Member

@esune esune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

Copy link
Contributor

@loneil loneil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested out the config permutations locally, working for me. The connectionless proof is working now after the attachment change
Just minor change now that we can update to the latest RC of 1.0.0

docker/docker-compose.yaml Outdated Show resolved Hide resolved
Signed-off-by: Gavin Jaeger-Freeborn <gavinfreeborn@gmail.com>
@esune esune merged commit c2bbfc7 into main Jul 26, 2024
6 checks passed
@esune esune deleted the present_proof_2 branch July 26, 2024 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to use present-proof 2.0
5 participants