Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sandboxing to modules #214

Draft
wants to merge 86 commits into
base: master
Choose a base branch
from
Draft

Add sandboxing to modules #214

wants to merge 86 commits into from

Commits on Jun 10, 2024

  1. (feat): Sandboxing start

    @hyblocker
    hyblocker committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    c87be67 View commit details
    Browse the repository at this point in the history

  2. (feat): Implement basic main function

    @hyblocker
    hyblocker committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    62ca044 View commit details
    Browse the repository at this point in the history

  3. (chore): Fix incorrect indentation in csproj

    @hyblocker
    hyblocker committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    4e1e216 View commit details
    Browse the repository at this point in the history

  4. (feat): Stub for subprocess IPC

    @hyblocker
    hyblocker committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    9bc5312 View commit details
    Browse the repository at this point in the history

  5. (chore): Fix incorrect configuration matrix for projects

    @hyblocker
    hyblocker committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    fa3deea View commit details
    Browse the repository at this point in the history

  6. (feat): Barebones named pipe client

    @hyblocker
    hyblocker committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    ba649da View commit details
    Browse the repository at this point in the history

  7. (feat): Begin implementing the IPC protocol 

    We want to minimise the amount of data transferred between the module and VRCFT. We should use the UE version number to disallow incompatible versions of modules to communicate with the program. We want to minimise the data transferred to minimise latency between modules and destination programs,

I am aiming for a C-like structure with a fixed memory size so that the data is always going to be N bytes large, so that the JIT can optimise it away into a super fast memcpy call.
    @hyblocker
    hyblocker committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    010521f View commit details
    Browse the repository at this point in the history

  8. (feat): Implement barebones named pipe server

    @hyblocker
    hyblocker committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    fd70edc View commit details
    Browse the repository at this point in the history

  9. (feat): UnifiedTracking proxy stub

    @hyblocker
    hyblocker committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    f5ef832 View commit details
    Browse the repository at this point in the history

  10. (feat): Slightly more complete sub-process main function.

    @hyblocker
    hyblocker committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    e0fd420 View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2024

  1. (feat): Define IpcPacket

    @hyblocker
    hyblocker committed Jun 16, 2024
    Configuration menu
    Copy the full SHA
    f86ddcb View commit details
    Browse the repository at this point in the history

  2. (fix): Remove unsafe for ModuleProcess

    @hyblocker
    hyblocker committed Jun 16, 2024
    Configuration menu
    Copy the full SHA
    41ee627 View commit details
    Browse the repository at this point in the history

  3. (chore): Move VrcftSandboxClient to Core

    @hyblocker
    hyblocker committed Jun 16, 2024
    Configuration menu
    Copy the full SHA
    57ada22 View commit details
    Browse the repository at this point in the history

  4. (chore): Remove named pipe subprocess classes

    @hyblocker
    hyblocker committed Jun 16, 2024
    Configuration menu
    Copy the full SHA
    36fa73a View commit details
    Browse the repository at this point in the history

  5. (feat): Create IPC packet stubs

    @hyblocker
    hyblocker committed Jun 16, 2024
    Configuration menu
    Copy the full SHA
    e789a4b View commit details
    Browse the repository at this point in the history

  6. (feat): Implement handshake packet

    @hyblocker
    hyblocker committed Jun 16, 2024
    Configuration menu
    Copy the full SHA
    4079f6f View commit details
    Browse the repository at this point in the history

  7. (feat): Move VrcftSandboxServer from named pipes to udp

    @hyblocker
    hyblocker committed Jun 16, 2024
    Configuration menu
    Copy the full SHA
    5fb2ba0 View commit details
    Browse the repository at this point in the history

  8. (feat): Move module main process to udp instead of named pipes

    @hyblocker
    hyblocker committed Jun 16, 2024
    Configuration menu
    Copy the full SHA
    cf326e8 View commit details
    Browse the repository at this point in the history

  9. (chore): Update exit code enum name

    @hyblocker
    hyblocker committed Jun 16, 2024
    Configuration menu
    Copy the full SHA
    95e0782 View commit details
    Browse the repository at this point in the history

  10. (feat): Cleanup UnifiedTracking.Proxy

    @hyblocker
    hyblocker committed Jun 16, 2024
    Configuration menu
    Copy the full SHA
    b7d6067 View commit details
    Browse the repository at this point in the history

  11. (feat): Implement VrcftPacketDecoder

    @hyblocker
    hyblocker committed Jun 16, 2024
    Configuration menu
    Copy the full SHA
    5a041cc View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2024

  1. (feat): Implement full duplex UDP server

    @hyblocker
    hyblocker committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    6e8d9bf View commit details
    Browse the repository at this point in the history

  2. (fix): Make IpcPacket usable

    @hyblocker
    hyblocker committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    2541991 View commit details
    Browse the repository at this point in the history

  3. (feat): Implement full duplex sever/client

    @hyblocker
    hyblocker committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    3c8c0d0 View commit details
    Browse the repository at this point in the history

  4. (fix): Fix VrcftPacketDecoder

    @hyblocker
    hyblocker committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    74f5d54 View commit details
    Browse the repository at this point in the history

  5. (feat): Begin implementing sandboxing to UnifiedLibManager

    @hyblocker
    hyblocker committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    f9e748f View commit details
    Browse the repository at this point in the history

  6. (feat): Add logging to ModuleProcess

    @hyblocker
    hyblocker committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    0a2dd08 View commit details
    Browse the repository at this point in the history

  7. (fix): Move server initialisation to initialize

    @hyblocker
    hyblocker committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    aff1726 View commit details
    Browse the repository at this point in the history

  8. (fix): Only create the server once.

    @hyblocker
    hyblocker committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    8bf49ec View commit details
    Browse the repository at this point in the history

  9. (feat): Add robust CLI args to the sandbox process

    @hyblocker
    hyblocker committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    1e17272 View commit details
    Browse the repository at this point in the history

  10. (feat): Add 30 sec timeout to module subprocesses

    @hyblocker
    hyblocker committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    8941ce2 View commit details
    Browse the repository at this point in the history

  11. (chore): Rewrite packet handler to use switch

    @hyblocker
    hyblocker committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    fbf6c1a View commit details
    Browse the repository at this point in the history

  12. (chore): Add overloads to send by port

    @hyblocker
    hyblocker committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    2ba5e87 View commit details
    Browse the repository at this point in the history

  13. (fix): Fix accessor for port

    @hyblocker
    hyblocker committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    e173d61 View commit details
    Browse the repository at this point in the history

  14. (fix): Update proxy logger to forward log events

    @hyblocker
    hyblocker committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    4190307 View commit details
    Browse the repository at this point in the history

  15. (fix): Tiny delay in startup to fix timing issues

    @hyblocker
    hyblocker committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    a4e202e View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2024

  1. (feat): Improve client sevrer implementations

    @hyblocker
    hyblocker committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    fcc56ac View commit details
    Browse the repository at this point in the history

  2. (feat): Implement wrapper around modules

    @hyblocker
    hyblocker committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    c4f0f2a View commit details
    Browse the repository at this point in the history

  3. (chore): Fix indentation, add constants

    @hyblocker
    hyblocker committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    607dd02 View commit details
    Browse the repository at this point in the history

  4. (feat): Implement some packets

    @hyblocker
    hyblocker committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    26c9298 View commit details
    Browse the repository at this point in the history

  5. (feat): Make VRCFT start sub-processes

    @hyblocker
    hyblocker committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    32eafd1 View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2024

  1. (feat): Wrap module sub-process in try catch

    @hyblocker
    hyblocker committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    5ecb7d5 View commit details
    Browse the repository at this point in the history

  2. (feat): Add more packet types

    @hyblocker
    hyblocker committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    ca00805 View commit details
    Browse the repository at this point in the history

  3. (feat): Disallow some ports

    @hyblocker
    hyblocker committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    0784783 View commit details
    Browse the repository at this point in the history

  4. (hack): Add error handling for missing subprocess exe

    @hyblocker
    hyblocker committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    792448a View commit details
    Browse the repository at this point in the history

  5. (feat): Handle module initialisation

    @hyblocker
    hyblocker committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    eca95b0 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2024

  1. (feat): Add more packet events

    @hyblocker
    hyblocker committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    9d4cbd1 View commit details
    Browse the repository at this point in the history

  2. (fix): Fix incorrect config matrix again

    @hyblocker
    hyblocker committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    314dafd View commit details
    Browse the repository at this point in the history

  3. (chore): Correct wording error in comment

    @hyblocker
    hyblocker committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    6663381 View commit details
    Browse the repository at this point in the history

  4. (feat): Properly initialise a module instance

    @hyblocker
    hyblocker committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    dd9e981 View commit details
    Browse the repository at this point in the history

  5. (feat): Implement VRCFT update packet

    @hyblocker
    hyblocker committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    027ca44 View commit details
    Browse the repository at this point in the history

  6. (feat): Implement other packets

    @hyblocker
    hyblocker committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    46a3571 View commit details
    Browse the repository at this point in the history

  7. (feat): Add warning on missing packet type in decoder

    @hyblocker
    hyblocker committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    2c56c64 View commit details
    Browse the repository at this point in the history

  8. (feat): Fix issues with UDP Full Duplex crashing / closing connection

    @hyblocker
    hyblocker committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    5da24af View commit details
    Browse the repository at this point in the history

  9. (feat): Implement sandboxing flow

    @hyblocker
    hyblocker committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    cc8e212 View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2024

  1. (fix): Add receive timeout of 10s

    @hyblocker
    hyblocker committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    409be27 View commit details
    Browse the repository at this point in the history

  2. (fix): Fix OSCQuery not functioning properly

    @hyblocker
    hyblocker committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    a49f0f9 View commit details
    Browse the repository at this point in the history

  3. (fix): Only update global state when available and set

    @hyblocker
    hyblocker committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    fcbfcf4 View commit details
    Browse the repository at this point in the history

  4. (feat): Keep track of whether a module supports ET and FT

    @hyblocker
    hyblocker committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    522d215 View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2024

  1. (fix): Add default parameters for eye openness so that eyes initialis… 

    …e as open.
    @hyblocker
    hyblocker committed Jul 14, 2024
    Configuration menu
    Copy the full SHA
    aadab60 View commit details
    Browse the repository at this point in the history

  2. (fix): Handle sub-process logging properly

    @hyblocker
    hyblocker committed Jul 14, 2024
    Configuration menu
    Copy the full SHA
    2b83dd7 View commit details
    Browse the repository at this point in the history

  3. (fix): Only apply gaze data when it's valid

    @hyblocker
    hyblocker committed Jul 14, 2024
    Configuration menu
    Copy the full SHA
    e58923a View commit details
    Browse the repository at this point in the history

  4. (fix): Fix race condition preventing sub-processes from timing out on… 

    … exit
    @hyblocker
    hyblocker committed Jul 14, 2024
    Configuration menu
    Copy the full SHA
    cc5dce3 View commit details
    Browse the repository at this point in the history

  5. (feat): Make whether or not a module is enabled or not a lot clearer

    @hyblocker
    hyblocker committed Jul 14, 2024
    Configuration menu
    Copy the full SHA
    0194a8d View commit details
    Browse the repository at this point in the history

  6. (chore): Elaborate on rationale for long timeout 

    Ideally later we can give different timeouts depending on the stage the module is in during it's lifetime
    @hyblocker
    hyblocker committed Jul 14, 2024
    Configuration menu
    Copy the full SHA
    938fb12 View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2024

  1. Merge branch 'benaclejames:master' into sandboxing

    @hyblocker
    hyblocker authored Jul 15, 2024
    Configuration menu
    Copy the full SHA
    aaf6c7b View commit details
    Browse the repository at this point in the history

  2. (feat): Make whether a module is enabled or not clearer

    @hyblocker
    hyblocker committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    c4427cc View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2024

  1. (fix): Styling issues on the ToggleButton

    @hyblocker
    hyblocker committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    2f3d23c View commit details
    Browse the repository at this point in the history

  2. (feat): Make the output page colour log lines based on severity

    @hyblocker
    hyblocker committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    99679bd View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2024

  1. (fix): Enable VRCFT to accept incoming modules

    @hyblocker
    hyblocker committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    bf24f0a View commit details
    Browse the repository at this point in the history

  2. (chore): Remove pre-sandboxing module handling

    @hyblocker
    hyblocker committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    e76820b View commit details
    Browse the repository at this point in the history

  3. (feat): Hide module sub-process windows outside debug mode 

    This is to make VRCFT more usable but still convenient for constant debugging and restarts
    @hyblocker
    hyblocker committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    996572e View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2024

  1. Merge branch 'benaclejames:master' into sandboxing

    @hyblocker
    hyblocker authored Jul 20, 2024
    Configuration menu
    Copy the full SHA
    bb7e9fd View commit details
    Browse the repository at this point in the history

  2. (fix): Fix VRCFT crashing when a module crashes

    @hyblocker
    hyblocker committed Jul 20, 2024
    Configuration menu
    Copy the full SHA
    552c92f View commit details
    Browse the repository at this point in the history

  3. (fix): Handle sub-module process rejoining better

    @hyblocker
    hyblocker committed Jul 20, 2024
    Configuration menu
    Copy the full SHA
    83ced77 View commit details
    Browse the repository at this point in the history

  4. (fix): Make teardown more reliable

    @hyblocker
    hyblocker committed Jul 20, 2024
    Configuration menu
    Copy the full SHA
    35e4807 View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2024

  1. (fix): Handle win32 errors for killing sub-processes

    @hyblocker
    hyblocker committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    9e1f3b7 View commit details
    Browse the repository at this point in the history

  2. (chore): Add stub strings for non-English languages 

    We should flag language maintainers to update these strings accordingly
    @hyblocker
    hyblocker committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    5af0246 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2024

  1. (fix): Fix Publish being broken for module process

    @hyblocker
    hyblocker committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    cc93d98 View commit details
    Browse the repository at this point in the history

  2. (fix): Correct build configuration matrix

    @hyblocker
    hyblocker committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    be84f53 View commit details
    Browse the repository at this point in the history

  3. (fix): Make shutting down modules not crash VRCFT

    @hyblocker
    hyblocker committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    3928c18 View commit details
    Browse the repository at this point in the history

  4. (feat): Implement partial packets. 

    MD doc describing how these are formatted coming soon™️
    @hyblocker
    hyblocker committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    94db620 View commit details
    Browse the repository at this point in the history

  5. (feat): Load module icons

    @hyblocker
    hyblocker committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    5c366f6 View commit details
    Browse the repository at this point in the history

  6. (feat): Only commit modified values to global state. 

    This uses an invalid value of 0xFFFFFFFF currently. Might be worthwhile changing it into a NaN or some similar value later.
    @hyblocker
    hyblocker committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    8eac836 View commit details
    Browse the repository at this point in the history

  7. (chore): Add some debug utils to UnifiedLibManager

    @hyblocker
    hyblocker committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    7b82fa6 View commit details
    Browse the repository at this point in the history

  8. (fix): ModuleProcess breaking publish again??

    @hyblocker
    hyblocker committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    d83f4ed View commit details
    Browse the repository at this point in the history