Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose /pure build that doesnt depend on OS or require #1179

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Andarist
Copy link

This is just a proof of concept - I would gladly work on this to move it through the finish line. However, those kinds of changes might really depend on personal preferences etc so I might need some guidance and code review to do that.

Why?
I'm using a Babel parser and I don't want to pull in a dependency like esprima if I don't have to.

How?

  • created a new /pure entrypoint. The name is questionable and I'm happy to change it - I've just wanted this to be terse and couldn't figure out a better one on the spot
  • I've removed deprecated esprima option
  • I've also removed dual @babel/parser/babylon loading
  • and I've removed the dependency on require("os").EOL. I can bring it back in a similar fashion - by splitting the pure and impure files and only using this in the "impure" one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant