Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: fix libgit 1.1.0 compability #6

Closed
wants to merge 1 commit into from
Closed

deps: fix libgit 1.1.0 compability #6

wants to merge 1 commit into from

Conversation

chenrui333
Copy link

closes #5

relates to Homebrew/homebrew-core#65706

@bennorth
Copy link
Owner

Hi, thanks for the PR. It would be good to move literate-git to the current pygit2, yes. I'm fine with removing Python 3.5 support, since it became end-of-life a couple of months ago, but I'm reluctant to remove Python 3.6 and Python 3.7 from the Travis config. I've made an experimental branch update-pygit2 which removes the venvgit2 requirement, as it seems that pygit2 is now packaged in a way which doesn't require it. This successfully built and passed tests under the Travis focal image, for Pythons 3.6, 3.7, 3.8, and 3.9.

I'm not familiar with the details of how Homebrew operates, sorry, but might something like this work for you? If so, I'll tidy it up and make a new release.

@aspiers
Copy link

aspiers commented Nov 29, 2020

Any idea how libgit2 gets provided in this Travis environment? I can't see it mentioned in the build log you reference, so I'm guessing it's pre-included in the focal image, but not sure. I see your build uses sudo rather than containers so there may be room for getting faster builds by switching to containers ... but then you might run into a vaguely similar challenge to what I had with aspiers/git-deps#73. See also the linked issue travis-ci/apt-package-safelist#4285.

@bennorth
Copy link
Owner

@aspierslibgit2 arrives as part of the binary pygit2 wheel. From its docs: Libgit2 v1.1.x; binary wheels already include libgit2, so you only need to worry about this if you install the source package.

@aspiers
Copy link

aspiers commented Nov 29, 2020

Ahhh, thanks! That sounds like some newer magic which maybe didn't exist a few years ago when I last looked at this. Or maybe I just missed it.

@bennorth
Copy link
Owner

I've just pushed changes to develop (967caf4) which move to pygit2>=1.4.0, so I'm closing this. Please re-open if this doesn't address your use-case with Homebrew.

@bennorth bennorth closed this Mar 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

need a new release for pygit2 1.4.0
3 participants