Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: publish json schemas as release artifacts #540

Merged
merged 14 commits into from
Sep 17, 2024

Conversation

v-rocheleau
Copy link
Contributor

@v-rocheleau v-rocheleau commented Sep 16, 2024

  • new django manage.py script schemas to generate single file JSON-schemas for phenopackets, experiments and discovery
  • new release github actions workflow is triggered on new releases and adds the schemas to the release as an artifact zip file

Tested with a dummy pre-release with a PR trigger.
The content of the json-schemas-clean.zip artifact is what it will look like on a real release, but with the json-schemas.zip name (artifacts cannot be overriden, so I changed the names as I was testing to avoid errors).

Copy link

codecov bot commented Sep 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.99%. Comparing base (5a3da67) to head (4dac651).
Report is 15 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #540   +/-   ##
========================================
  Coverage    90.99%   90.99%           
========================================
  Files          131      131           
  Lines         4939     4939           
  Branches       705      705           
========================================
  Hits          4494     4494           
  Misses         299      299           
  Partials       146      146           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@v-rocheleau v-rocheleau changed the title chore: init action to publish json schemas as release artifacts chore: publish json schemas as release artifacts Sep 16, 2024
@davidlougheed
Copy link
Member

you can probably fix the errors right now by setting up python, running poetry install before export, and doing poetry run ./manage.py [...] in order to use the poetry env to run the script.

Copy link
Member

@davidlougheed davidlougheed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@v-rocheleau v-rocheleau merged commit 3c7e196 into develop Sep 17, 2024
7 checks passed
@v-rocheleau v-rocheleau deleted the features/schema-artifacts branch September 17, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants