Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(actions): single release workflow trigger for pre-release and stable #543

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

v-rocheleau
Copy link
Contributor

The published release type is triggered for both stable and pre-release.
Having both published and prerelease caused the workflow to run in double on pre-releases.

Copy link
Member

@davidlougheed davidlougheed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.90%. Comparing base (fe3cb86) to head (32dc7ea).
Report is 4 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #543      +/-   ##
===========================================
- Coverage    90.99%   90.90%   -0.09%     
===========================================
  Files          131      127       -4     
  Lines         4939     4893      -46     
  Branches       705      693      -12     
===========================================
- Hits          4494     4448      -46     
  Misses         299      299              
  Partials       146      146              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@v-rocheleau v-rocheleau merged commit 06699e2 into develop Sep 19, 2024
6 of 7 checks passed
@v-rocheleau v-rocheleau deleted the fix/release-workflow-trigger branch September 19, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants