テスト実行をpytestに移行 #17
Merged
テスト実行をpytestに移行 #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kashewnuts
force-pushed
the
migrate-pytest
branch
from
438e693
to
d95a46c
Compare
kashewnuts
force-pushed
the
migrate-pytest
branch
2 times, most recently
from
b3f0124
to
ada523c
Compare
kashewnuts
force-pushed
the
migrate-pytest
branch
from
ada523c
to
41718f8
Compare
kashewnuts
commented
Aug 5, 2024
| @@ -33,8 +29,7 @@ | |||
| ], | |||
| }, | |||
| ] | |||
|
|
|||
| CELERY_TASK_ALWAYS_EAGER = True | |||
| USE_TZ = False # For Django 5.0+ | |||
There was a problem hiding this comment.
MEMO: Django5.0で値が変更されるので明示的に設定
RemovedInDjango50Warning: The default value of USE_TZ will change from False to True in Django 5.0. Set USE_TZ to False in your project settings if you want to keep the current default behavior.
warnings.warn(
-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
| @@ -1,7 +0,0 @@ | |||
| # See http://peak.telecommunity.com/DevCenter/setuptools#namespace-packages | |||
There was a problem hiding this comment.
以下のように非推奨であるメッセージがでるので [beproud/django/__init__.py](https://github.com/beproud/bpnotify/pull/17/files#diff-b84fb5fc7ef473b9cb42b0a428ef8da21bc7978986580b82b657b8cbb288498d) と合わせて削除
.tox/py311-dj42-celery53/lib/python3.11/site-packages/pkg_resources/__init__.py:121
/Users/kashew/projects/github.com/beproud/bpnotify/.tox/py311-dj42-celery53/lib/python3.11/site-packages/pkg_resources/__init__.py:121: DeprecationWarning: pkg_resources is deprecated as an API
warnings.warn("pkg_resources is deprecated as an API", DeprecationWarning)
beproud/__init__.py:3
/Users/kashew/projects/github.com/beproud/bpnotify/beproud/__init__.py:3: DeprecationWarning: Deprecated call to `pkg_resources.declare_namespace('beproud')`.
Implementing implicit namespace packages (as specified in PEP 420) is preferred to `pkg_resources.declare_namespace`. See https://setuptools.pypa.io/en/latest/references/keywords.html#keyword-namespace-packages
__import__('pkg_resources').declare_namespace(__name__)
beproud/django/__init__.py:3
/Users/kashew/projects/github.com/beproud/bpnotify/beproud/django/__init__.py:3: DeprecationWarning: Deprecated call to `pkg_resources.declare_namespace('beproud.django')`.
Implementing implicit namespace packages (as specified in PEP 420) is preferred to `pkg_resources.declare_namespace`. See https://setuptools.pypa.io/en/latest/references/keywords.html#keyword-namespace-packages
__import__('pkg_resources').declare_namespace(__name__)
.tox/py311-dj42-celery53/lib/python3.11/site-packages/pkg_resources/__init__.py:2349
/Users/kashew/projects/github.com/beproud/bpnotify/.tox/py311-dj42-celery53/lib/python3.11/site-packages/pkg_resources/__init__.py:2349: DeprecationWarning: Deprecated call to `pkg_resources.declare_namespace('beproud')`.
Implementing implicit namespace packages (as specified in PEP 420) is preferred to `pkg_resources.declare_namespace`. See https://setuptools.pypa.io/en/latest/references/keywords.html#keyword-namespace-packages
declare_namespace(parent)
-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
There was a problem hiding this comment.
知らない人のために一応参考記事を貼っておきますね
Python 3.3b1 の名前空間パッケージを試してみた — 清水川Web
| @@ -1,3 +0,0 @@ | |||
| from setuptools import setup | |||
|
|
|||
| setup(test_suite="tests.main") | |||
There was a problem hiding this comment.
python setup.py test コマンドのために残していただけなので削除
Comment on lines
+53
to
+56
| # For Celery Tests | ||
| app = celery.Celery() | ||
| app.config_from_object('django.conf:settings', namespace='CELERY') | ||
| app.autodiscover_tasks(lambda: INSTALLED_APPS) |
There was a problem hiding this comment.
ここだけ追加している。他はimport順&記述内容の整理
| @@ -1,46 +0,0 @@ | |||
| import os | |||
Comment on lines
+11
to
+12
| * Celery (5.3) | ||
| * Django (4.2) |
shimizukawa
approved these changes
Aug 7, 2024
| @@ -15,7 +15,7 @@ jobs: | |||
| strategy: | |||
| matrix: | |||
| python-version: ['3.9', '3.10', '3.11', '3.12'] | |||
| django-version: ['3.2', '4.2'] | |||
|
|
||
| * Drop Django3.2&Celery5.2 | ||
| * Migrate from ``python setup.py test`` to ``pytest`` | ||
|
|
||
| 0.49 (2024-02-XX) |
| @@ -1,7 +0,0 @@ | |||
| # See http://peak.telecommunity.com/DevCenter/setuptools#namespace-packages | |||
There was a problem hiding this comment.
知らない人のために一応参考記事を貼っておきますね
Python 3.3b1 の名前空間パッケージを試してみた — 清水川Web
| "Framework :: Django :: 4.2", | ||
| "Intended Audience :: Developers", | ||
| "Environment :: Plugins", | ||
| "Topic :: Software Development :: Libraries :: Python Modules", | ||
| ] | ||
| dependencies = ["Django>=3.2", "six", "Celery"] | ||
| dependencies = ["Django>=4.2", "six", "Celery"] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
目的
具体的な変更内容
python -m build && twine check時のログ