Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add details for tested devices to README #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

seriousManual
Copy link

No description provided.

@TimPietrusky
Copy link
Member

@seriousManual you tested this with both the MK2 and the USB DMX Pro?

@TimPietrusky TimPietrusky self-requested a review December 3, 2018 14:08
@TimPietrusky TimPietrusky self-assigned this Dec 3, 2018
@TimPietrusky
Copy link
Member

I just tested this with the MK2 and it's working.

Need to verify the USB DMX Pro too.

@seriousManual
Copy link
Author

I tested it with the USB DMX Pro (https://www.thomann.de/de/enttec_dmx_usb_pro_interface.htm).

Copy link
Member

@TimPietrusky TimPietrusky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some changes regarding the correct name of the family (which should be DMX USB PRO) and the name of the manufacturer (they write themselves like this on their website: ENTTEC)

@@ -1,6 +1,10 @@
# fivetwelve driver for ENTTEC USB PRO mk2
# fivetwelve driver for the USB PRO family by enttec
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say "the DMX USB PRO family by ENTTEC", because that is what you would search for.


This is a [fivetwelve][] driver for the [USB PRO mk2][usbpromk2] DMX-interface made by enttec.
This is a [fivetwelve][] driver for the USBPRO DMX-interface family made by enttec.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also the same for this: "DMX USB PRO family made by ENTTEC".

This is a [fivetwelve][] driver for the USBPRO DMX-interface family made by enttec.
From this line the following devices have been tested:

* [Enttec USB Pro][usbpro]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ENTTEC DMX USB PRO

From this line the following devices have been tested:

* [Enttec USB Pro][usbpro]
* [Enttec USB Pro mk2][usbpromk2]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ENTTEC DMX USB PRO MK2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants