Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add $parameters to shouldRegisterNavigation #249

Merged
merged 2 commits into from
Oct 27, 2023
Merged

add $parameters to shouldRegisterNavigation #249

merged 2 commits into from
Oct 27, 2023

Conversation

rupadana
Copy link
Contributor

from filament v3.0.57 they overriding shouldRegisterNavigation and adding $parameters into it.

@what-the-diff
Copy link

what-the-diff bot commented Oct 11, 2023

PR Summary

  • Modification to shouldRegisterNavigation Method in HasPageShield.php File
    The method has been updated to accept an array of parameters as input. It then proceeds to return the result of invoking the parent class's shouldRegisterNavigation method. This change enhances the flexibility and general usability of the function.

@bezhanSalleh bezhanSalleh merged commit f92d88c into bezhanSalleh:3.x Oct 27, 2023
5 checks passed
@rominronin rominronin mentioned this pull request Jul 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bezhanSalleh bezhanSalleh bezhanSalleh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rupadana @bezhanSalleh