Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First stab at implementing draft-ietf-sidrops-8210bis-14 #126

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

job
Copy link
Member

@job job commented Aug 7, 2024

Copy link
Collaborator

@benjojo benjojo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume its still in WIP, but make sure the unit tests are not nulled out before merging :)

@job
Copy link
Member Author

job commented Aug 7, 2024

I assume its still in WIP, but make sure the unit tests are not nulled out before merging :)

hah, nice, thanks for pointing that out

@job job requested a review from benjojo August 7, 2024 12:43
@marenamat
Copy link
Contributor

while testing against BIRD, we found out that if one doesn't explicitly request -protocol 2, then after BIRD sends Serial Query with verson set to 2, StayRTR replies with Cache Response but version set to 1

supposing that both sides are violating the draft here, section 7, because in this case, StayRTR should either accept version 2, or send Error Report with code 4, and BIRD should, after receiving a different version, probably drop the session as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants