-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Add CLI tool for filename validation for use in pre-receive hooks #1700
Conversation
@nellh What would be a good format for dataset_description? Right now it's:
We could do:
This would be kinda backwards compatible, as the |
3ab24bf
to
7c05f08
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1700 +/- ##
==========================================
- Coverage 87.93% 83.89% -4.04%
==========================================
Files 16 16
Lines 1351 1416 +65
==========================================
Hits 1188 1188
- Misses 163 228 +65 ☔ View full report in Codecov by Sentry. |
The 0001 is a particular git-protocol-ism, and 0000 does not behave as I expected. Instead of adding multiple 0001s and attempting to identify the meaning, the new protocol preceeds the old protocol with a header line and a single JSON line.
087ccb4
to
ec42201
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@effigies I merged this too soon on the OpenNeuro side but looks fine with a couple fixes (see suggested changes). Anything else we should address to merge this?
Co-authored-by: Nell Hardcastle <nell@dev-nell.com>
This is a basic validator that accepts a
.bidsignore
list and a list of files. The use case is to quickly determine if a git push should be accepted by a server.Todo:
dataset_description.json
from stdin, and enable derivativesfnmatch
filtering