-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/bmspt 283 delegate methods #23
base: develop
Are you sure you want to change the base?
Conversation
… clipping plane and line builders
… clipping plane and line builders
* [BMSPT-275] implementation of bcf zip creation with memory stream * [BMSPT-275] refactor & reorganization * [BMSPT-275] added unit tests * Simplified IConverter API. Added support for predefined output streams. * [BMSPT-297] Checking incoming streams if they can be used for the given use case. Added documentation. --------- Co-authored-by: DanielLepold <daniel@bimspot.io> Co-authored-by: Adam Eri <adam.eri@blackmirror.at>
…18) * [BMSPT-293] Added cancellation token to Converter stream operations. * [BMSPT-293] Added cancellation token to Converter stream operations. --------- Co-authored-by: Adam Eri <adam.eri@bimspot.io>
…, refactoring, extended worker with converter ToBcf fns, supporting cancellation token and output stream
…re/BMSPT-283-delegate-methods # Conflicts: # bcf-toolkit.sln.DotSettings.user # src/bcf-toolkit/Builder/Bcf21/Interfaces/IViewPointBuilder.cs # src/bcf-toolkit/Builder/Bcf30/Interfaces/IViewPointBuilder.cs # src/bcf-toolkit/Builder/Bcf30/ViewPointBuilder.cs # src/bcf-toolkit/Converter/Bcf21/Converter.cs # src/bcf-toolkit/Converter/Bcf21/FileWriter.cs # src/bcf-toolkit/Converter/Bcf21/SchemaConverterToBcf30.cs # src/bcf-toolkit/Converter/Bcf30/Converter.cs # src/bcf-toolkit/Converter/Bcf30/FileWriter.cs # src/bcf-toolkit/Converter/Bcf30/SchemaConverterToBcf21.cs # src/bcf-toolkit/Model/Bcf21/MarkupExtensions.cs # src/bcf-toolkit/Model/Bcf21/VisInfo.cs # src/bcf-toolkit/Model/Bcf30/MarkupExtensions.cs # src/bcf-toolkit/Program.cs # src/bcf-toolkit/README.md # src/bcf-toolkit/Utils/BcfExtensions.cs # src/bcf-toolkit/Utils/ZipArchiveEntryExtensions.cs # src/bcf-toolkit/Utils/ZipArchiveExtensions.cs # src/tests/Converter/Bcf21/FileWriterTest.cs # src/tests/Converter/Bcf30/ConverterTests.cs # src/tests/Converter/Bcf30/FileWriterTests.cs # src/tests/WorkerTests.cs
…er and converter, fixed and extended tests, extended readme
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pls consider the following solutions for the "return Task.Completed case":
if (_delegate is null) {
throw new InvalidOperationException("IBcfBuilderDelegate is not set.");
}
if (_delegate is null) {
return Task.FromException(new InvalidOperationException("IBcfBuilderDelegate is not set."));
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the commented-out parts remain for future use?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work!
Pls see my comments
Description
PR includes the delegate callback function and stream process func for converters.
Fixes
Type Of Change
to not work as expected)
API Changes
Environment (Docker)
Checklist