refactor: pass string format arguments as logging method parameters

The logging statement has the call of the form `logging.(format_string % (format_args...))`. For such calls, it is recommended to leave string interpolation to the logging method itself and be written as `logging.(format_string, format_args...)` so that the program may avoid incurring the cost of the interpolation in those cases in which no message will be logged. For more details, see [PEP 282](http://www.python.org/dev/peps/pep-0282).
biocommons · Sep 9, 2023 · 076d4c1 · 076d4c1
1 parent 4f4796d
commit 076d4c1
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/biocommons/example/__main__.py b/src/biocommons/example/__main__.py
@@ -23,7 +23,7 @@ def main():  # pragma: no cover
     )
 
     quote = marvin.get_quote()
-    _logger.warning("Got quote from Marvin (len=%s)" % (len(quote),))
+    _logger.warning("Got quote from Marvin (len=%s)", len(quote))
 
     print("Marvin says:")
     print(quote)

diff --git a/src/biocommons/example/marvin.py b/src/biocommons/example/marvin.py
@@ -40,6 +40,6 @@ def get_quote() -> str:
 
     quote = random.choice(quotes)
 
-    _logger.info("Got quote from Marvin (len=%s)" % (len(quote),))
+    _logger.info("Got quote from Marvin (len=%s)", len(quote))
 
     return quote