Merge pull request #32 from biocommons/4-add-pyright-support-to-cicd

Add pyright checking, use pre-commit for code reformatting

.pre-commit-config.yaml

@@ -6,6 +6,11 @@ repos:
        entry: flake8
        language: system
        types: [python]
+    -  id: pyright
+       name: pyright
+       entry: pyright
+       language: system
+       types: [python]
     -  id: isort
        name: isort
        entry: isort

Makefile

@@ -62,13 +62,6 @@ build: %:
 #= TESTING
 # see test configuration in setup.cfg
 
-#=> cqa: execute code quality tests
-cqa:
-	flake8 src --count --select=E9,F63,F7,F82 --show-source --statistics
-	isort --profile black --check src
-	black --check src
-	bandit -ll -r src
-
 #=> test: execute tests
 #=> test-code: test code (including embedded doctests)
 #=> test-docs: test example code in docs
@@ -86,17 +79,21 @@ test-%:
 tox:
 	tox
 
+#=> cqa: execute code quality tests
+cqa:
+	flake8 src --show-source --statistics
+	pyright
+	isort --check src --profile black
+	black --check src
+	bandit -ll -r src
 
-############################################################################
-#= UTILITY TARGETS
-
-#=> reformat: reformat code with yapf and commit
+#=> reformat: reformat code
 .PHONY: reformat
 reformat:
-	@if ! git diff --cached --exit-code >/dev/null; then echo "Repository not clean" 1>&2; exit 1; fi
-	black src tests
-	isort src tests
-	git commit -a -m "reformatted with black and isort"
+	pre-commit
+
+############################################################################
+#= UTILITY TARGETS
 
 #=> rename: rename files and substitute content for new repo name
 .PHONY: rename

pyproject.toml

@@ -29,12 +29,13 @@ dev = [
 	"flake8 ~= 4.0",
 	"ipython ~= 8.4",
 	"isort ~= 5.10",
-	"mypy",
+	"mypy-extensions ~= 1.0",
 	"pre-commit ~= 3.4",
 	"pylint ~= 2.14",
 	"pytest-cov ~= 4.1",
 	"pytest-optional-tests",
 	"pytest ~= 7.1",
+	"pyright~=1.1",
 	"tox ~= 3.25",
 	"vcrpy",
 ]
@@ -127,7 +128,11 @@ line-length = 100
 
 [tool.isort]
 profile = "black"
-src_paths = ["src"]
+src_paths = ["src", "tests"]
+
+
+[tool.pyright]
+include = ["src", "tests"]
 
 
 [tool.pylint.'MESSAGES CONTROL']

src/biocommons/example/tests/conftest.py

@@ -1,4 +1,4 @@
-import importlib
+import importlib.resources
 
 import pytest
 import yaml