Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update python-package workflow to use trusted publishing #50

Merged
merged 5 commits into from
Sep 1, 2024

Conversation

korikuzma
Copy link
Contributor

@korikuzma korikuzma commented Jul 22, 2024

close #39

Additional changes:

  • Update action versions + python version used

close #39

Additional changes:
* Only run workflow when a tag is created
* Update action versions + python version used
@korikuzma korikuzma requested a review from reece July 22, 2024 20:51
@korikuzma korikuzma self-assigned this Jul 22, 2024
@korikuzma korikuzma requested a review from a team as a code owner July 22, 2024 20:51
jsstevenson
jsstevenson previously approved these changes Jul 23, 2024
Copy link

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the stale Issue is stale and subject to automatic closing label Aug 22, 2024
@korikuzma korikuzma removed the stale Issue is stale and subject to automatic closing label Aug 26, 2024
@korikuzma
Copy link
Contributor Author

In biocommons maintainers 8/26 meeting, we decided GitHub environments are not needed at this time.

@reece
Copy link
Member

reece commented Sep 1, 2024

@korikuzma Have you figured out how to test this action? I tried two tags and a commit, but no luck. I'm going to merge and try.

Copy link
Member

@reece reece left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @korikuzma !

@reece reece merged commit 21f173b into main Sep 1, 2024
9 checks passed
@reece reece deleted the 39-use-trusted-publishling-for-pypi-release branch September 1, 2024 23:40
@reece
Copy link
Member

reece commented Sep 2, 2024

I updated the tag expressions after merge to accommodate alpha, beta, rc, dev, and post tags.

@reece
Copy link
Member

reece commented Sep 2, 2024

And it worked...

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use trusted publishling for pypi release
3 participants