-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update python-package.yml #68
Conversation
I think we need this change to fix the deploy action
@korikuzma maybe this is a good time to add the trusted publishing component from the example repo? |
@jsstevenson I agree. @reece would you be able to add trusted publishing on pypi? |
@andreasprlic trusted publishing has been setup on pypi. Would you be able to update the file using the example here? You'll only need to change this line: https://github.com/biocommons/biocommons.example/blob/main/.github/workflows/python-package.yml#L129 |
@reece I was not able to reproduce the local unit test error that you ran into in today's collective coding meeting.
|
@bsgiles73 same |
@korikuzma I replaced the python-package.yml with the one from the template and updated the pypi bioutils URL accordingly. It looks like it needs a few more tweaks though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh my bad, didn't see tests are failing now
@korikuzma after a few more tweaks (in Makefile), tests are passing. |
I think we need this change to fix the deploy action