Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option lineage #197

Merged
merged 3 commits into from
Apr 1, 2021
Merged

Option lineage #197

merged 3 commits into from
Apr 1, 2021

Conversation

cehbrecht
Copy link
Member

Overview

This PR adds the wps lineage option to the birdy client.

Changes:

  • Added lineage option in WPSClient.
  • Updated rook demo notebook with lineage option.
  • Removed outdated rook notebooks.

Related Issue / Discussion

roocs/rooki#67

Additional Information

If lineage is "true", the Execute operation response shall include the DataInputs and OutputDefinitions elements.

http://geoprocessing.info/wpsdoc/1x0Execute

@cehbrecht cehbrecht requested a review from Zeitsperre April 1, 2021 15:22
@cehbrecht cehbrecht self-assigned this Apr 1, 2021
Copy link
Contributor

@Zeitsperre Zeitsperre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just wondering, but do we want to implement the nbstripout hook (https://github.com/kynan/nbstripout) for notebooks here? We can set it to save outputs from specific cells, as needed. What are your thoughts @cehbrecht

@cehbrecht
Copy link
Member Author

Looks good. Just wondering, but do we want to implement the nbstripout hook (https://github.com/kynan/nbstripout) for notebooks here? We can set it to save outputs from specific cells, as needed. What are your thoughts @cehbrecht

good idea :) So, we don't forget it to clean the notebooks.

@cehbrecht cehbrecht merged commit 34c330c into master Apr 1, 2021
@cehbrecht cehbrecht deleted the option-lineage branch April 1, 2021 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants