Release/v1.9.18 #7324
Open
Release/v1.9.18 #7324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We try to connect to the first 7 Bitcoin Core nodes always in the same order. Only if connections to these nodes fail we look further into the list. This change shuffles the node addresses before passing them to BitcoinJ thus removing the bias from the first 7 prioritized nodes.
When the user uses our federated BTC nodes, we merge the hard-coded nodes with the ones provided by the filter. The hard-coded node's operator field is set to the node's operator and operator field of the nodes from the filter is set to "Provided by filter". When the same BTC node is in the hard-coded list and the filter, Bisq adds both to the merged list because the operator field is different. This change explicitly marks the onionAddress, hostName, address, and port field to be used in the hashCode and equals implementation.
The fromFullAddress method parsed hostnames as IPV4 addresses instead as hostnames.
Bisq accepts IPV6 node addresses but the NodeAddress can't parse them.
The FederatedBtcNodeProvider compared the list of banned nodes with each BtcNode's hostname instead of checking a BtcNode's hostname, ip address, and onion address.
…r-v1.9.18 Update data stores for v1.9.18
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.