feat: automated stopping remoted service on darwin #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've committed it by accident, so I'm removing it now.
michal-przytarski
force-pushed
the
stop-remoted
branch
from
74ee1e8
to
0dc2543
Compare
eryk-tkaczewski
approved these changes
Sep 23, 2024
SmartBearAR
reviewed
Sep 23, 2024
| @@ -48,7 +47,7 @@ func (t Tunnel) Close() error { | |||
| // ManualPairAndConnectToTunnel tries to verify an existing pairing, and if this fails it triggers a new manual pairing process. | |||
| // After a successful pairing a tunnel for this device gets started and the tunnel information is returned | |||
| func ManualPairAndConnectToTunnel(ctx context.Context, device ios.DeviceEntry, p PairRecordManager) (Tunnel, error) { | |||
| log.Info("ManualPairAndConnectToTunnel: starting manual pairing and tunnel connection, dont forget to stop remoted first with 'sudo pkill -SIGSTOP remoted' and run this with sudo.") | |||
| logrus.Info("ManualPairAndConnectToTunnel: starting manual pairing and tunnel connection, dont forget to run this with sudo.") | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added stopping remoted service on establishing tunnel connection of darwin OS, as it is said in docs, that is should be done manually