Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPV-838(feat) AdminAPI #744

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

SPV-838(feat) AdminAPI #744

wants to merge 17 commits into from

Conversation

ac4ch
Copy link
Contributor

@ac4ch ac4ch commented Oct 17, 2024

Pull Request Checklist

  • πŸ“– I created my PR using provided : CODE_STANDARDS
  • πŸ“– I have read the short Code of Conduct: CODE_OF_CONDUCT
  • 🏠 I tested my changes locally.
  • βœ… I have provided tests for my changes.
  • πŸ“ I have used conventional commits.
  • πŸ“— I have updated any related documentation.
  • πŸ’Ύ PR was issued based on the Github or Jira issue.

@ac4ch ac4ch requested a review from a team as a code owner October 17, 2024 09:49
Copy link

Manual Tests

ℹ️ Remember to ask team members to perform manual tests and to assign tested label after testing.

@codecov-commenter
Copy link

codecov-commenter commented Oct 17, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 9.05109% with 623 lines in your changes missing coverage. Please review.

Project coverage is 45.07%. Comparing base (38fdab7) to head (420e8f0).

Files with missing lines Patch % Lines
actions/admin/paymail_addresses_old.go 0.00% 113 Missing ⚠️
actions/admin/contact_old.go 0.00% 106 Missing ⚠️
actions/admin/transactions_old.go 0.00% 77 Missing ⚠️
actions/admin/xpubs_old.go 0.00% 56 Missing ⚠️
actions/admin/utxos_old.go 0.00% 45 Missing ⚠️
actions/admin/access_keys_old.go 0.00% 39 Missing ⚠️
actions/admin/webhooks_old.go 0.00% 35 Missing ⚠️
actions/admin/transactions.go 0.00% 27 Missing ⚠️
actions/admin/contact.go 0.00% 22 Missing ⚠️
actions/admin/paymail_addresses.go 0.00% 21 Missing ⚠️
... and 7 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #744      +/-   ##
==========================================
- Coverage   46.13%   45.07%   -1.07%     
==========================================
  Files         328      335       +7     
  Lines       16700    17174     +474     
==========================================
+ Hits         7705     7741      +36     
- Misses       8421     8859     +438     
  Partials      574      574              
Flag Coverage Ξ”
unittests 45.07% <9.05%> (-1.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Ξ”
actions/admin/destinations.go 0.00% <ΓΈ> (ΓΈ)
actions/admin/routes.go 100.00% <100.00%> (ΓΈ)
docs/docs.go 0.00% <ΓΈ> (ΓΈ)
actions/admin/webhooks.go 0.00% <0.00%> (ΓΈ)
engine/action_paymails.go 47.33% <0.00%> (-3.75%) ⬇️
actions/admin/xpubs.go 0.00% <0.00%> (ΓΈ)
engine/tx_repository.go 36.43% <0.00%> (-3.74%) ⬇️
actions/admin/access_keys.go 0.00% <0.00%> (ΓΈ)
engine/action_transaction.go 24.40% <0.00%> (-1.63%) ⬇️
actions/admin/utxos.go 0.00% <0.00%> (ΓΈ)
... and 10 more

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update 38fdab7...420e8f0. Read the comment docs.

@ac4ch ac4ch enabled auto-merge (squash) October 18, 2024 06:18
@ac4ch ac4ch disabled auto-merge October 18, 2024 06:18
@ac4ch ac4ch added the regression-tests Runs regression tests label Oct 18, 2024
actions/admin/transactions.go Show resolved Hide resolved
actions/admin/transactions.go Outdated Show resolved Hide resolved
actions/admin/utxos.go Outdated Show resolved Hide resolved
actions/admin/webhooks.go Outdated Show resolved Hide resolved
actions/admin/xpubs.go Outdated Show resolved Hide resolved
engine/spverrors/definitions.go Outdated Show resolved Hide resolved
engine/spverrors/definitions.go Outdated Show resolved Hide resolved
engine/spverrors/definitions.go Outdated Show resolved Hide resolved
@ac4ch ac4ch enabled auto-merge (squash) October 18, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression-tests Runs regression tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants