Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove wif #82

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

feat: remove wif #82

wants to merge 4 commits into from

Conversation

ChrisCho-H
Copy link
Contributor

removed wif dependency and toWIF function

@ChrisCho-H ChrisCho-H mentioned this pull request Aug 30, 2023
Closed
@junderw
Copy link
Member

junderw commented Aug 30, 2023

You need to use npm@v6 otherwise you break the package-lock file for older clients.

@ChrisCho-H
Copy link
Contributor Author

fix it!
appreciate if published to npm 🙏

junderw
junderw approved these changes Aug 30, 2023
View reviewed changes
Copy link
Member

@junderw junderw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Might take a while before pushing a major version bump.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@junderw junderw junderw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChrisCho-H @junderw