Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support taproot for signAllInputsHD #2137

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

feat: support taproot for signAllInputsHD #2137

wants to merge 6 commits into from

Conversation

jasonandjay
Copy link
Member

  • issue discussion: Feature Request: Taproot support for signAllInputsHD #2132
  • feat
    • affected Signature Methods
      • signAllInputsHD
      • signAllInputsAsyncHD
      • signInputHD
      • signInputAsyncHD
    • remove conflict default sighashTypes of signInputHD
      • Transaction.SIGHASH_DEFAULT for _signTaprootInput
      • Transaction.SIGHASH_ALL for _signInput
      • so we should remove the outermost default signType
    • add integration test for HDWallet with tapBip32Derivation
      • we will need more integration tests later.

@jasonandjay

This comment was marked as resolved.

Sign in to view
@jasonandjay
Copy link
Member Author

How about code review progress?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@junderw junderw Awaiting requested review from junderw

@motorina0 motorina0 Awaiting requested review from motorina0

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jasonandjay