-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: calculate segwit, taproot and script hash input/output bytes #82
base: master
Are you sure you want to change the base?
feat: calculate segwit, taproot and script hash input/output bytes #82
Conversation
+1 for this. I may have to go as far as using @ChrisCho-H 's fork / branch directly in my package.json since we use Segwit and it'd save us a lot on fees if this can't get in by the end of the month... @Overtorment could you review? ❤️ I looked it over and the calculation looks ok, but I'm not intimately familiar with TX size calculation. |
thanks a lot. it works for p2pkh, p2sh and p2wpkh(segwit). |
@LeeKorbisCa I published my forked version to npm |
@Overtorment could you please review when you've got a moment? 😃 (Pinging you since it seems junderw delegates to you :)) |
@ChrisCho-H I'm now using your fork in the meantime. Thank you again for publishing this |
|
@junderw maybe you can help with the review? The feature with seg-wit & TapRoot coin selection seems to be very necessary for JS bitcoiners |
@landabaso would u mind to review it? |
add logic to calculate segwit, taproot and script hash input and output to support satoshi per vbyte.