Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make constant file pub #14

Closed
wants to merge 1 commit into from
Closed

Make constant file pub #14

wants to merge 1 commit into from

Conversation

itsyaasir
Copy link
Contributor

Motivation

Closes #

Changes

Test Plan

TODO

  • Explain motivation or link existing issue(s)
  • Test changes and document test plan
  • Update documentation as needed

DevOps Notes

  • This PR does not require configuration changes (e.g., environment variables, GitHub secrets, VM resources)
  • This PR does not affect public APIs
  • This PR does not rely on a new version of external services
  • This PR does not make changes to log messages (which monitoring infrastructure may rely on)

By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.

@kobby-pentangeli
Copy link
Contributor

Those constants are used internally for appending the reveal script to the script builder. Any particular reason why they should be exported?

@itsyaasir itsyaasir closed this Mar 21, 2024
@itsyaasir itsyaasir deleted the itsyaasir/expose-constants branch March 21, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blutooth blutooth Awaiting requested review from blutooth

@kobby-pentangeli kobby-pentangeli Awaiting requested review from kobby-pentangeli

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@itsyaasir @kobby-pentangeli