feat: added runestone to reveal tx #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 4660214.
Maximkaaa
requested changes
Jul 31, 2024
src/wallet/builder.rs
Outdated
| // tx out | ||
| #[cfg(feature = "rune")] |
There was a problem hiding this comment.
This feature-based logic inside a method seems like something impossible to support in future, and would probably not work correctly for some use cases.
What's even more confusing is that the type is called OrdTransactionBuilder using RevealTransactionArgs but we build a runestone transaction instead that has nothing to do with ord or with reveal.
I think if we want to use this crate in future, it would be better to invest some time to refactor the code to be less confusing and more correct.
There was a problem hiding this comment.
@Maximkaaa Actually etching requires an inscription. I agree with your point, so at least I've created a dedicated function for this in the rune module.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Added the possibility to pass the runestone to the reveal transaction. This allows etching and minting for runes.
Changes
Added
runestoneargument to Reveal transaction args.