Fix return wrong TTL when pumping job from the secondary storage #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, we put now() + TTL as the expired time when storing jobs in database, but didn't remove the now() after pumping jobs. This PR also remove unused function `BatchGetJobs` which is similar with GetReadyJobs.
Codecov Report
@@ Coverage Diff @@
## master #218 +/- ##
==========================================
- Coverage 56.05% 55.92% -0.13%
==========================================
Files 38 38
Lines 2983 2961 -22
==========================================
- Hits 1672 1656 -16
+ Misses 1093 1090 -3
+ Partials 218 215 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we put now() + TTL as the expired time when storing jobs in the database,
but didn't remove the now() after pumping jobs. This PR also removes
the unused function
BatchGetJobswhich is similar to GetReadyJobs.