Search and show #15
Merged
Search and show #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a search bar, a peer show view, a basic shards show view, and enable search by both peer or by secret name.
Completes #7
In the future I'd like to make this more extensible but that means removing dependencies on suggest-box and writing a manual query for ssb users, and merging that into our own manual secrets query. So this gives the required functionality for the moment. Due to using depject, another dependency I'd like to remove in future, I cannot locate where exactly this is happening (its in the
about.async.suggestmodule but that doesn't appear to be in Patchcore... even though it must be where we're getting it from?).Another job for future is rewrite suggest for multiple options.