Fix crash in release mode for mdns example #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
control_buffer was going out of scope Closes bltavares#14
|
Thanks for the PR! I cant review it properly for the next few weeks tho,
but I'll check back as soon as I can
…On Tue, Nov 28, 2023, 01:36 Will ***@***.***> wrote:
control_buffer was going out of scope
Closes #14 <#14>
------------------------------
You can view, comment on, or merge this pull request online at:
#16
Commit Summary
- 5eca9a8
<5eca9a8>
Fix crash in release mode for mdns example
File Changes
(1 file <https://github.com/bltavares/multicast-socket/pull/16/files>)
- *M* src/win.rs
<https://github.com/bltavares/multicast-socket/pull/16/files#diff-b63b84b571bbdfc96282bb5c880e95a18ecb7b23235d45a2e9c0b5b1c3236c0c>
(2)
Patch Links:
- https://github.com/bltavares/multicast-socket/pull/16.patch
- https://github.com/bltavares/multicast-socket/pull/16.diff
—
Reply to this email directly, view it on GitHub
<#16>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAA2XIXYBYNG72BZZWJ46J3YGUWX3AVCNFSM6AAAAAA743PIVSVHI2DSMVQWIX3LMV43ASLTON2WKOZSGAYTGMZXGQ2DCNA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
|
Sorry for taking too long to merge it, but I've tested it on my Windows dev enviroment and it looks good. I might want to rethink how this code works so the control buffer moves along with the WSABuf so it does not happen again, but for now it's great. Thank you for your contribution. |
|
Published multicast-socket |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
control_buffer was going out of scope
Closes #14