Move to meson-python
#433
Merged
Move to meson-python
#433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Depends on conda-forge/arrow-cpp-feedstock#1530 |
|
@alippai @SimeonStoykovQC If one of you could do a review of this PR, I would highly appreciate it. |
alippai
reviewed
Sep 12, 2024
| #include <turbodbc_numpy/set_numpy_parameters.h> | ||
| #include <turbodbc/cursor.h> | ||
|
|
||
| // compare http://docs.scipy.org/doc/numpy/reference/c-api.array.html#importing-the-api |
alippai
reviewed
Sep 12, 2024
meson.build
Outdated
| # Don't use the deprecated NumPy C API. Define this to a fixed version instead of | ||
| # NPY_API_VERSION in order not to break compilation for released SciPy versions | ||
| # when NumPy introduces a new deprecation. | ||
| numpy_nodepr_api = ['-DNPY_NO_DEPRECATED_API=NPY_1_9_API_VERSION'] |
There was a problem hiding this comment.
I see this is copied from SciPy, but I wonder why NPY_1_9_API_VERSION (or NPY_1_7_API_VERSION) and not the minimum numpy?
alippai
reviewed
Sep 12, 2024
pixi.toml
Outdated
| numpy = ">=1.21,<3" | ||
| cmake = ">=3.30.2,<3.31" | ||
| libboost-devel = ">=1.86.0,<1.87" | ||
| simdutf = ">=5.4.15,<5.5" |
There was a problem hiding this comment.
I don't think this matches the conda feedstock meta.yaml
There was a problem hiding this comment.
I'll expand this a bit.
|
I have no C++ build experience, but looks much simpler than it was before. |
|
Running into prefix-dev/setup-pixi#139 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch the build backend to
mesonpy. This should future-proof this package and removes the need for two different build systems.At the same time we're switching to
pixiinstead of usingcondaand Earthly together. We could probably utilisepixitasks a bit more, but that is something for a future cleanup.