Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terminate applet on manager termination if it was started by manager #2486

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Terminate applet on manager termination if it was started by manager #2486

merged 1 commit into from
Sep 10, 2024

Conversation

cschramm
Copy link
Member

@cschramm cschramm commented Sep 8, 2024

Closes #2482

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@cschramm cschramm enabled auto-merge (rebase) September 8, 2024 18:41
infirit
infirit approved these changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@infirit infirit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could construct the proxy and don't automatically autostart so we can check if the proxy has a name owner (proxy.get_name_owner() returns None if not running). I'm not sure how this impacts the rest of blueman and this looks good to me.

@cschramm cschramm merged commit fa74af2 into blueman-project:main Sep 10, 2024
21 checks passed
@cschramm cschramm deleted the oneshot branch September 12, 2024 20:55
@cschramm cschramm mentioned this pull request Oct 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infirit infirit infirit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

blueman-applet does not exit automatically when blueman-manager is closed
2 participants
@cschramm @infirit