Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use provided value of trigger_value #1219

Merged
merged 9 commits into from
Oct 29, 2024

Conversation

prjemian
Copy link
Contributor

Tested identical change locally at APS as part of aps-8id-dys/bluesky#95 and aps-8id-dys/bluesky#99.

@prjemian prjemian self-assigned this Oct 29, 2024
@prjemian prjemian added the bug label Oct 29, 2024
@tacaswell
Copy link
Contributor

How hard would it be to add a test for this?

@prjemian
Copy link
Contributor Author

How easy is it to create triggerable Signal that requires a testable value? test matrix should include 1, "1!" (since that is our case, and maybe some other type (maybe bool?).

@prjemian
Copy link
Contributor Author

Probably want it to appear in the documentation, too. This is a great feature and it required some investigation to uncover this capability.

@prjemian
Copy link
Contributor Author

Document a Device's trigger_value kwarg in a separate issue.

@prjemian
Copy link
Contributor Author

CI failure (in one Py3.11 configuration) does not look related to this work:

/home/runner/work/_temp/351d6ed9-ee3e-433a-adbc-efc7e5388f9b.sh: line 1:  3115 Segmentation fault      (core dumped) pytest -k "${TEST_CL}"
ophyd/tests/test_areadetector.py 

@prjemian
Copy link
Contributor Author

Kept re-running that test configuration until it passed.

@tacaswell tacaswell merged commit 52c082d into master Oct 29, 2024
15 checks passed
@tacaswell tacaswell deleted the 1218-use-the-value-of-trigger_value branch October 29, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provided value of trigger_value is ignored
2 participants