Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: clean deprecated code #593

Merged
merged 52 commits into from
Sep 23, 2024
Merged

feat: clean deprecated code #593

merged 52 commits into from
Sep 23, 2024

Conversation

cosinlink
Copy link
Collaborator

@cosinlink cosinlink commented Aug 27, 2024

CI
{
"hardfork": "pascal",
"bsc": "bnb-chain/bsc@9579134"
}
CI

Description

clean deprecated code and add ci to compare genesis with bytecode files from bsc repo

for deprecated contracts and functions:

  1. non-view and non-pure external functions => revert
  2. view or pure external functions => not change
  3. internal functions => removed

Example

local check without ci

export HARDFORK=pascal
export BSC_URL=https://github.com/bnb-chain/bsc/pull/2692/commits/f7ab40e46171af937a70767bb0221653d574eafe
ts-node scripts/check-bsc-hardfork-bytecode.ts

Rationale

Preventing the exploitation of deprecated code for security

Changes

Notable changes:

  1. non-view and non-pure external functions => revert
  2. view or pure external functions => not change
  3. internal functions => removed
  4. add ci check bytecode

pythonberg1997
pythonberg1997 previously approved these changes Aug 27, 2024
@pythonberg1997
Copy link
Collaborator

pythonberg1997 commented Aug 28, 2024

_decodeMigrationSynPackage and _doMigration in StakeHub are no longer needed

@cosinlink
Copy link
Collaborator Author

_decodeMigrationSynPackage and _doMigration in StakeHub are no longer needed

removed

@cosinlink cosinlink changed the title feat: clean deprecated code feat: clean deprecated code [hardfork:pascal] Sep 8, 2024
@cosinlink cosinlink changed the title feat: clean deprecated code [hardfork:pascal] feat: clean deprecated code [pascal hardfork] Sep 8, 2024
@cosinlink cosinlink changed the title feat: clean deprecated code [pascal hardfork] feat: clean deprecated code [pascal hardfork Sep 8, 2024
@cosinlink cosinlink changed the title feat: clean deprecated code [pascal hardfork feat: clean deprecated code Sep 8, 2024
@unclezoro unclezoro merged commit 4c03f82 into develop Sep 23, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants