Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some string optimizations #4030

Merged
merged 12 commits into from
Nov 11, 2024
Merged

Conversation

CrazyboyQCD
Copy link
Contributor

@CrazyboyQCD CrazyboyQCD commented Nov 6, 2024

Copy link

codecov bot commented Nov 6, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 318 lines in your changes missing coverage. Please review.

Project coverage is 52.89%. Comparing base (6ddc2b4) to head (1bfe1ef).
Report is 287 commits behind head on main.

Files with missing lines Patch % Lines
core/engine/src/builtins/regexp/mod.rs 49.01% 26 Missing ⚠️
...ore/engine/src/builtins/temporal/plain_time/mod.rs 0.00% 23 Missing ⚠️
...ore/engine/src/builtins/temporal/plain_date/mod.rs 0.00% 21 Missing ⚠️
core/engine/src/builtins/intl/collator/mod.rs 0.00% 20 Missing ⚠️
core/engine/src/builtins/intl/plural_rules/mod.rs 0.00% 19 Missing ⚠️
core/engine/src/builtins/intl/date_time_format.rs 0.00% 18 Missing ⚠️
.../engine/src/builtins/intl/number_format/options.rs 0.00% 15 Missing ⚠️
core/engine/src/builtins/temporal/duration/mod.rs 0.00% 15 Missing ⚠️
core/engine/src/builtins/intl/list_format/mod.rs 0.00% 13 Missing ⚠️
core/engine/src/builtins/promise/mod.rs 7.69% 12 Missing ⚠️
... and 38 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4030      +/-   ##
==========================================
+ Coverage   47.24%   52.89%   +5.64%     
==========================================
  Files         476      483       +7     
  Lines       46892    46943      +51     
==========================================
+ Hits        22154    24829    +2675     
+ Misses      24738    22114    -2624     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CrazyboyQCD CrazyboyQCD changed the title [boa-engine]: Some string optimizations Some string optimizations Nov 8, 2024
@CrazyboyQCD CrazyboyQCD marked this pull request as draft November 8, 2024 02:27
@CrazyboyQCD CrazyboyQCD marked this pull request as ready for review November 9, 2024 04:08
Copy link
Contributor

@hansl hansl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two non-blocking nits, but otherwise everything is pretty straightforward.

LGTM.

core/engine/src/builtins/string/mod.rs Outdated Show resolved Hide resolved
core/engine/src/module/mod.rs Show resolved Hide resolved
Copy link
Contributor

@hansl hansl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@jedel1043 jedel1043 requested a review from a team November 10, 2024 21:15
@nekevss nekevss added this pull request to the merge queue Nov 11, 2024
Merged via the queue into boa-dev:main with commit f30514b Nov 11, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Perf: replace js_str! with js_string! where argument is to be converted to JsString to reduce heap allocation
4 participants