Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 4 API for Go 1.23 #22

Merged
merged 8 commits into from
Aug 16, 2024
Merged

Version 4 API for Go 1.23 #22

merged 8 commits into from
Aug 16, 2024

Conversation

bobg
Copy link
Owner

@bobg bobg commented Aug 5, 2024

This PR updates go-generics to new major version 4 for the release of Go 1.23.

Version 4 removes the iter and maps packages.

The iter.Of[T] type was made obsolete with the introduction of Go 1.23 iterators. The functionality previously available for iter.Of[T] iterators has now been replicated for Go 1.23 iterators in the github.com/bobg/seqs package (qv).

The maps package was mostly redundant with the Go standard library.

Additionally, combinatorial operations previously found in the slices package have now moved to github.com/bobg/combo.

Copy link

github-actions bot commented Aug 14, 2024

Modver result

This report was generated by Modver,
a Go package and command that helps you obey semantic versioning rules in your Go module.

This PR requires an increase in your module’s major version number.
If the new major version number is 2 or greater,
you must also add or update the version suffix
on the module path defined in your go.mod file.
See the Go Modules Reference for more info.

no new version of package github.com/bobg/go-generics/v3/iter
  Major

Copy link

github-actions bot commented Aug 14, 2024

Pull Request Test Coverage Report for Build 10398031835

Details

  • 89 of 95 (93.68%) changed or added relevant lines in 4 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+3.3%) to 91.188%

Changes Missing Coverage Covered Lines Changed/Added Lines %
parallel/parallel.go 9 12 75.0%
slices/slices.go 41 44 93.18%
Files with Coverage Reduction New Missed Lines %
parallel/parallel.go 1 79.17%
Totals Coverage Status
Change from base Build 10237406652: 3.3%
Covered Lines: 476
Relevant Lines: 522

💛 - Coveralls

@bobg bobg changed the title Bobg/v4b Version 4 API for Go 1.23 Aug 16, 2024
@bobg bobg marked this pull request as ready for review August 16, 2024 14:43
@bobg bobg merged commit 1998b09 into master Aug 16, 2024
1 check passed
@bobg bobg deleted the bobg/v4b branch August 16, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant