Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ~func type params in parallel package #23

Merged
merged 3 commits into from
Aug 17, 2024
Merged

Conversation

bobg
Copy link
Owner

@bobg bobg commented Aug 17, 2024

Forgot this before creating the v4.0.0 release (which is now retracted in favor of v4.1.0): removing the ~func(...) type parameters from the functions in parallel.

Copy link

github-actions bot commented Aug 17, 2024

Modver result

This report was generated by Modver,
a Go package and command that helps you obey semantic versioning rules in your Go module.

This PR requires an increase in your module’s major version number.
If the new major version number is 2 or greater,
you must also add or update the version suffix
on the module path defined in your go.mod file.
See the Go Modules Reference for more info.

checking Pool
  in type parameters of func[T, U any, F ~func(T) (U, error)](n int, f F) func(T) (U, error)
    went from 3 type parameter(s) to 2
      Major

@coveralls
Copy link

coveralls commented Aug 17, 2024

Pull Request Test Coverage Report for Build 10429263492

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.4%) to 91.068%

Files with Coverage Reduction New Missed Lines %
parallel/parallel.go 2 79.17%
Totals Coverage Status
Change from base Build 10421785002: -0.4%
Covered Lines: 469
Relevant Lines: 515

💛 - Coveralls

@bobg bobg merged commit 50a3d39 into master Aug 17, 2024
1 check passed
@bobg bobg deleted the bobg/no-tilde-func branch August 17, 2024 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants